Ensure device nodes can be parsed from contents #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @xolox !
Came across an issue parsing the contents of a package using
deb_pkg_tools
today. Packages which reference device nodes (granted odd and obscure but do exist), populate the size field of these nodes as their block device IDs inls
anddpkg-deb -c
:This causes a
ValueError
when attempting to coerce the parsed size value as an integer within theinspect_package_contents
function:Change below simply wraps the assignment and cast in a try/catch and ensures the size is reported zero. It's not quite correct that its zero sized, but it does allow for the cast, and ensures the types remain the same within the
ArchiveEntry
tuple for other users.Let me know if you need anything else here.
Thanks!
Tom