Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting large negative numbers minor issue #40

Closed
pernlofgren opened this issue Apr 30, 2020 · 1 comment
Closed

Formatting large negative numbers minor issue #40

pernlofgren opened this issue Apr 30, 2020 · 1 comment

Comments

@pernlofgren
Copy link

Noticed that the function format_number returns a a leading comma after the minus sign for negative numbers with a set of digits that is a multiple of 3. Just wanted to flag here in case it was unknown :)

Current behaviour:

difference = -285.671623847
humanfriendly.format_number(difference)
Out[118]: '-,285.67'

Expected behaviour:

difference = -285.671623847
humanfriendly.format_number(difference)
Out[118]: '-285.67'
xolox added a commit that referenced this issue Dec 1, 2020
See the changelog update for details.
This fixes #30, #40 and #43.
@xolox
Copy link
Owner

xolox commented Dec 1, 2020

Hi Pernilla, thanks for the feedback and sorry for the late response.

I've just published humanfriendly 9.0 which fixes the issue you reported.

Cheers!

@xolox xolox closed this as completed Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants