Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable useful in libvirt 2.0.0 #1

Closed
wants to merge 2 commits into from
Closed

Enable useful in libvirt 2.0.0 #1

wants to merge 2 commits into from

Conversation

qkboy
Copy link

@qkboy qkboy commented Jan 20, 2017

When run in CentOS 7.3 with libvirt 2.0.0 will not work. Because it has new directory/file naming scheme for channels:

/var/lib/libvirt/qemu/channel/target/domain-DOMAIN_ID-GUEST_NAME/negotiator-guest-to-host.0

xolox added a commit that referenced this pull request Mar 3, 2019
@xolox
Use 'virsh dumpxml' for channel discovery (related to #1)
333abb9
xolox added a commit that referenced this pull request Mar 3, 2019
@xolox
Optimize 'virsh dumpxml' channel discovery (related to #1)
d1c3faa 
The goal of these changes is to minimize the number of times that
the 'virsh dumpxml' command is called given the following points:

- Negotiator updates the list of workers every ten seconds.
- Dozens of virtual machines may be running on a single host.
- Not all virtual machines may support the negotiator interface.
- I'm slightly worried about how heavy 'virsh dumpxml' is
  and whether it involves any (exclusive) locking.

My initial naive implementation in 333abb9 was focused on making
channel discovery work using the new strategy, however it would result
in dozens of 'virsh dumpxml' calls every ten seconds. Despite the fact
that in my testing these calls take 0.03 seconds, the initial approach
still seemed like a rather brute force way of making things work...
xolox added a commit that referenced this pull request Mar 3, 2019
@xolox
Release 0.9: New channel discovery strategy (related to #1)
dd3bf78
xolox added a commit that referenced this pull request Mar 3, 2019
@xolox
Clarify that --verbose and --quiet can be repeated (related to #1)
9eb5355
xolox added a commit that referenced this pull request Mar 3, 2019
@xolox
Release 0.10: Clarify verbosity control, reduce log noise (related to #1
d421831 
)
@xolox
Copy link
Owner

xolox commented Mar 3, 2019

Hi @qkboy, thanks for the pull request and sorry it took me so long to respond. In the past days I published two new negotiator releases that are relevant to this pull request:

  • Release 0.9 made the channel discovery code compatible with libvirt versions that encode the domain id in the pathnames of the UNIX sockets. I decided to tackle this differently from the approach you suggested because I noticed that guest names may be truncated (the new code uses virsh dumpxml to find the pathnames of the channels, which means truncated names don't matter).

  • Release 0.10 updates the command line interface usage messages to clarify that the --verbose and --quiet options can be repeated to further increase/decrease the verbosity level, which means -vv is the same as the --debug option suggested in your pull request.

I'm going to close this pull request now, because as explained above I decided to implement libvirt 2.0.0 compatibility in a different way. Release 0.9 and 0.10 are now available on PyPI as well as GitHub. Thanks again for the feedback!

@xolox xolox closed this Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qkboy @xolox