add option patronizemenot aka do_prerun_fs_checks=false #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like flake8-docstring fails on python2 |
xolox
added a commit
that referenced
this pull request
Feb 11, 2020
xolox
added a commit
that referenced
this pull request
Feb 11, 2020
The mentioned issue / pull request made it clear to me that its very well possible for these (well intentioned) sanity checks to fail. Nevertheless I'm not inclined to just remove them. I do believe the changes here and in daa41a2 suitably accommodate the use case described in issue 18.
|
Please see my feedback and the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for issue #18 and allows the script to be used in a setup where the script does not have write permissions on a directory but the remove-command does. It also allows using the script with zfs snapshots, which are stored in a hidden .zfs/snapshot directory for which the existence check fails.