Errors when including syntax highlighted vim code block in a note

[citizenmatt]

If you create a note and type something like:

{{{vim
let g:vim_foo=1
}}}

the code block is correctly highlighted as vim code. However, if you add a new code block with a different language, e.g.

{{{java
}}}

as soon as you hit escape, you see the following errors:

Error detected while processing /usr/local/Cellar/macvim/7.4-73/MacVim.app/Contents/Resources/vim/runtime/syntax/vim.vim:
line  752:
E403: syntax sync: line continuations pattern specified twice
Press ENTER or type command to continue
Error detected while processing function xolox#notes#refresh_syntax..xolox#notes#highlight_sources:
line   21:
E170: Missing :endfor
Press ENTER or type command to continue
Error detected while processing function xolox#notes#refresh_syntax:
line    5:
E171: Missing :endif

and the new code block doesn't get syntax highlighting.

[xolox]

Thanks for the clear bug report. This should now be fixed. Happy Vimming!

[citizenmatt]

Wow, that was fast, thanks! I was just about to add a comment - I've been able to work around this error by only calling syntax_include once for each language, but I don't know vim script well enough to produce a decent patch, and my hacked version doesn't handle things nicely if a block is removed and then added again...

BTW, I know the code's MIT, but would you mind if I pinched this code for a PR for vim-markdown (full credit, of course)?

[xolox]

I would love to have this feature in Vim's markdown mode but it wasn't high priority enough to ever implement :-] so I would say go for it! I actually have a pull request open for vim-markdown myself (tpope/vim-markdown#9) but it was never merged (my fault), might have to pick that up again soon (I miss it).

Edit: Apparently I was talking about a different vim-markdown, but who cares, pinch it wherever you want, it's MIT ;-)

[citizenmatt]

Yeah, I've been looking at plasticboy's vim-markdown, which seems to have a few more features than the standard one from Mr Pope. Very cool PR, too, with the conceal features, and very interesting discussion, too. Tricky one to get right...

I've submitted a PR (preservim/vim-markdown#93) for just the syntax highlighting of code blocks, which makes a very nice addition to the formatting of the doc. I've handled the duplicate running of scripts a little differently, only including the new syntax if it's not already included. Seems to work fine.

Thanks for the original code!