Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of cwd not marking session as dirty #38

Closed
int3h opened this issue Feb 13, 2013 · 1 comment
Closed

Change of cwd not marking session as dirty #38

int3h opened this issue Feb 13, 2013 · 1 comment

Comments

@int3h
Copy link

int3h commented Feb 13, 2013

vim-session does not currently mark a session as dirty if the working directory changes. This means that if I open a session, 'cd' (or 'lcd') and then close the session, the updated session, with new working directory, will not be saved.

Out of curiosity, what is the reason for the dirty flag? Is it mainly so that users with autosave disabled won't get spurious save prompts?

My current thinking is that this feature may cause more problems than it solves. Dirty checks only check if the buffer list or layout have changed, which misses a lot of options that get saved with the session.

xolox added a commit that referenced this issue Apr 20, 2013
I never liked this code and the additional complexity it introduced, so
lets try without for a while and see if anyone complains. If I really want
to I can always get the code back from version control.

Pull request #37: #37
Issue #38: #38
@xolox
Copy link
Owner

xolox commented Apr 20, 2013

Hi Matthew,

Thanks for the feedback. This is now fixed (see the commit referenced above).

- Peter

@xolox xolox closed this as completed Apr 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants