New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/move to mocha #551

Merged
merged 7 commits into from Jan 6, 2017

Conversation

Projects
None yet
2 participants
@samhatoum
Member

samhatoum commented Jan 4, 2017

Uses Wallaby + Mocha + TestDouble instead of Jasmine / Jest

It's MUCH faster and TD is an easier API to work with than Jest

@samhatoum samhatoum merged commit d0a7e3a into master Jan 6, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@@ -0,0 +1,75 @@
const Chimp = require('./chimp');

This comment has been minimized.

@ejfrancis

ejfrancis Jan 7, 2017

Contributor

why is this test in src/lib/ while the other tests are in src/__tests_? should I be adding new tests to src/lib instead?

@ejfrancis

ejfrancis Jan 7, 2017

Contributor

why is this test in src/lib/ while the other tests are in src/__tests_? should I be adding new tests to src/lib instead?

This comment has been minimized.

@samhatoum

samhatoum Jan 7, 2017

Member

I'm moving all the spec files to be right next to their source files so your assumption is spot on. Thanks :)

@samhatoum

samhatoum Jan 7, 2017

Member

I'm moving all the spec files to be right next to their source files so your assumption is spot on. Thanks :)

This comment has been minimized.

@samhatoum

samhatoum Jan 7, 2017

Member

Interestingly, I'm using the same pattern you're making the PR to enable you to do

@samhatoum

samhatoum Jan 7, 2017

Member

Interestingly, I'm using the same pattern you're making the PR to enable you to do

This comment has been minimized.

@ejfrancis

ejfrancis Jan 7, 2017

Contributor

glad to see it!

@ejfrancis

ejfrancis Jan 7, 2017

Contributor

glad to see it!

@samhatoum samhatoum deleted the improvement/move-to-mocha branch Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment