Unit Test failure in test_integrations

[bobhy]

Unexpected unit test failures in brand new clone of master branch.

Running ubuntu 19.10, but python 3.8 in the venv for xonsh (3.71 comes preinstalled). Maybe that's the environment difference?

Current Behavior

Failures.

Traceback (if applicable)

============================= test session starts ==============================
platform linux -- Python 3.8.0, pytest-5.2.2, py-1.8.0, pluggy-0.13.0
rootdir: /mnt/myd/dev/src/xonsh, inifile: setup.cfg
plugins: timeout-1.3.3, cov-2.8.1, flake8-1.0.4, xonsh-0.9.13
collected 2148 items / 2132 deselected / 16 selected
run-last-failure: rerun previous 16 failures (skipped 630 files)

tests/test_integrations.py FFF                                           [ 18%]
tests/test_parser.py FFFFFF                                              [ 56%]

=================================== FAILURES ===================================
________________________________ test_printfile ________________________________

    @_bad_case
    def test_printfile():
>       check_run_xonsh("printfile.xsh", None, "printfile.xsh\n")

tests/test_integrations.py:471: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

cmd = 'printfile.xsh', fmt = None, exp = 'printfile.xsh\n'

    def check_run_xonsh(cmd, fmt, exp):
        """The ``fmt`` parameter is a function
        that formats the output of cmd, can be None.
        """
        out, err, rtn = run_xonsh(cmd, stderr=sp.PIPE)
        if callable(fmt):
            out = fmt(out)
        if callable(exp):
            exp = exp()
>       assert out == exp, err
E       AssertionError: /usr/bin/env: ‘python3 -u’: No such file or directory
E         /usr/bin/env: use -[v]S to pass options in shebang lines
E         
E       assert '' == 'printfile.xsh\n'
E         + printfile.xsh

tests/test_integrations.py:93: AssertionError
________________________________ test_printname ________________________________

    @_bad_case
    def test_printname():
>       check_run_xonsh("printfile.xsh", None, "printfile.xsh\n")

tests/test_integrations.py:476: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

cmd = 'printfile.xsh', fmt = None, exp = 'printfile.xsh\n'

    def check_run_xonsh(cmd, fmt, exp):
        """The ``fmt`` parameter is a function
        that formats the output of cmd, can be None.
        """
        out, err, rtn = run_xonsh(cmd, stderr=sp.PIPE)
        if callable(fmt):
            out = fmt(out)
        if callable(exp):
            exp = exp()
>       assert out == exp, err
E       AssertionError: /usr/bin/env: ‘python3 -u’: No such file or directory
E         /usr/bin/env: use -[v]S to pass options in shebang lines
E         
E       assert '' == 'printfile.xsh\n'
E         + printfile.xsh

tests/test_integrations.py:93: AssertionError
_______________________________ test_sourcefile ________________________________

    @_bad_case
    def test_sourcefile():
>       check_run_xonsh("printfile.xsh", None, "printfile.xsh\n")

tests/test_integrations.py:481: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

cmd = 'printfile.xsh', fmt = None, exp = 'printfile.xsh\n'

    def check_run_xonsh(cmd, fmt, exp):
        """The ``fmt`` parameter is a function
        that formats the output of cmd, can be None.
        """
        out, err, rtn = run_xonsh(cmd, stderr=sp.PIPE)
        if callable(fmt):
            out = fmt(out)
        if callable(exp):
            exp = exp()
>       assert out == exp, err
E       AssertionError: /usr/bin/env: ‘python3 -u’: No such file or directory
E         /usr/bin/env: use -[v]S to pass options in shebang lines
E         
E       assert '' == 'printfile.xsh\n'
E         + printfile.xsh

tests/test_integrations.py:93: AssertionError

Steps to Reproduce

1. git clone https://github.com/xonsh/xonsh.git
2. ...fiddle around installing python 3.8.0 in venv ...
3. vox active venv
4. pip install requirements/test.txt
5. py.test -q

[gforsyth]

Hey @bobhy -- the Python 3.8 failures are due to changes in the Python AST in 3.8 -- I have fixes for those in #3384 if you want to try out that branch. Otherwise you can downgrade to 3.7 and everything should pass.

Thanks for reporting!

[bobhy]

Hi @gforsyth -- when will the Python 3.8 AST fixes be merged into master? I have an unrelated enhancement ready to go, but I mistakenly pulled your fixes into my branch, so can't open a clean PR. If it will be a while, I will downgrade my dev environment and purify my branch.

[gforsyth]

Shouldn't be too long. Maybe a week, all told?

…

On Wed, Dec 25, 2019, 1:10 AM Bob Hyman ***@***.***> wrote: Hi @gforsyth <https://github.com/gforsyth> -- when will the Python 3.8 AST fixes be merged into master? I have an unrelated enhancement ready to go, but I mistakenly pulled your fixes into my branch, so can't open a clean PR. If it will be a while, I will downgrade my dev environment and purify my branch. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3397?email_source=notifications&email_token=AA3OFR5PVAABBKE2U46TLX3Q2L2NZA5CNFSM4JW2DZJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHT6OVQ#issuecomment-568846166>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA3OFR3XKKLP4BBSWVAKBALQ2L2NZANCNFSM4JW2DZJQ> .