Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC for issue #5358 #5429

Closed
wltb opened this issue May 20, 2024 · 1 comment
Closed

RFC for issue #5358 #5429

wltb opened this issue May 20, 2024 · 1 comment
Labels
completion to-close-in-the-future

Comments

@wltb
Copy link

wltb commented May 20, 2024

I also ran into the bug #5358, and left a comment that the root cause is very likely the missing check for None in this line. I fixed it on my machine, and had no trouble with the unconditional unpacking since then.

Since it got no reaction for a week now, I thought I'd better re-issue.
@anki-code anki-code mentioned this issue May 21, 2024
Merged
@anki-code
Copy link
Member

I've created PR. Many thanks @wltb !

jnoortheen pushed a commit that referenced this issue May 22, 2024
@anki-code
Fix 5379, 5429 (#5432)
f50a9e5 
Fix described in
#5358 (comment)
Closes #5379, #5429

## For community
⬇️ **Please click the 👍 reaction instead of leaving a `+1` or 👍
comment**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completion to-close-in-the-future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anki-code @wltb