Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when trying to send SIGSTOP to finished sudo child #2887

Merged
merged 2 commits into from Oct 17, 2018

Conversation

laloch
Copy link
Member

@laloch laloch commented Oct 16, 2018

Fixes #2883.
Although the Python's subprocess module does its best to not send signals to child processes that have already died, the protection is not atomic/race-free. We need to protect ourselves.

@laloch
Copy link
Member Author

laloch commented Oct 16, 2018

Is this worth a news entry?

@scopatz
Copy link
Member

scopatz commented Oct 16, 2018

Thanks for putting this in @laloch! Yes, please put in a new entry

@melund
Copy link
Member

melund commented Oct 17, 2018

Thanks @laloch. The python 35 test failure is unrelated to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants