-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading rc in non-interactive login shell #3422
Conversation
Hey @t0fik -- thanks for putting this in! Can you rebase/merge master in? There are some spurious CI failures that we can eliminate that way. Thanks! |
@gforsyth master merged. |
@anki-code when xonsh starts, it can be:
The old behavior only loaded RC files for interactive shells. This PR additionally loads RC files in the non-interactive+login case. |
@anki-code @astronouth7303 Exactly. The behaviour of Bash is the same. |
@t0fik great! Thanks! Am I right that
will works also? |
@anki-code Yes, it will work that way. |
Going to close/reopen to trigger CI |
Hi @t0fik - this seems to have some problems on Windows and needs black to be run on it |
@scopatz I fixed tests on Windows and ran black. Other problems seems to be not related with this PR. |
So I have restarted CI a few times, and I think this is related to the test failures. Can you take a closer look please? |
@scopatz My code is all green now. |
Thanks for pushing on this @t0fik !! This looks great. |
Also, I see this is your first contribution to |
Not loading rc files in
exec
mode was causing problems with setting up environment starting X session.Changes:
-l
cause loading environment. 'Fixes' How to running script with rc in command line? #3374xexec
implements options from bash/zshexec
command