-
-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3402 set the exit code for single commands #3632
Conversation
Thanks for putting this in @dyuri! Can you add a case or two here to the integration tests? |
Sure, on it. |
(I have no access to any windows machine so I've added |
Thanks! I think skipping windows makes sense for this feature. Also, can you please add a news item? |
News entry added. |
Sorry, I just noticed that on macOS |
Ok, now it seems to be fine, for some reason the checks for this PR used the old code (?), but in my fork they are all OK now: https://github.com/dyuri/xonsh/actions/runs/186758594 |
So I tried restarting and it didn't do anything. Maybe try merging from master? |
Yep, saw that, trying. |
Thanks! |
Attempt to fix #3402 .
(But it still does not seem to fix the issue with Fugitive.)