Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove custom handling of osc tokens for ptk prompt #4629

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

jnoortheen
Copy link
Member

https://github.com/prompt-toolkit/python-prompt-toolkit/blob/master/examples/prompts/finalterm-shell-integration.py

fixes #374

For community

⬇️ Please click the 👍 reaction instead of leaving a +1 or 👍 comment

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #4629 (bebb0d5) into main (c01fc6e) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4629      +/-   ##
==========================================
- Coverage   62.93%   62.88%   -0.05%     
==========================================
  Files         133      133              
  Lines       22610    22605       -5     
  Branches     4412     4409       -3     
==========================================
- Hits        14230    14216      -14     
- Misses       7263     7274      +11     
+ Partials     1117     1115       -2     
Flag Coverage Δ
linux 60.46% <100.00%> (-0.04%) ⬇️
macos 59.99% <100.00%> (-0.13%) ⬇️
windows 59.00% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xonsh/ptk_shell/shell.py 57.35% <100.00%> (+0.08%) ⬆️
xonsh/jobs.py 43.94% <0.00%> (-2.77%) ⬇️
xonsh/procs/pipelines.py 81.48% <0.00%> (-0.78%) ⬇️
xonsh/procs/posix.py 70.62% <0.00%> (-0.63%) ⬇️
xonsh/parsers/base.py 85.08% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c01fc6e...bebb0d5. Read the comment docs.

@gforsyth gforsyth merged commit 70dd8bf into xonsh:main Jan 7, 2022
@jnoortheen jnoortheen deleted the fix-ptk-osc branch January 7, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iTerm2 shell integration with xonsh
3 participants