Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $XONSH_TRACEBACK_LOGFILE path expansion #4713

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

yaxollum
Copy link
Member

Fixes #4696

For community

⬇️ Please click the 👍 reaction instead of leaving a +1 or 👍 comment

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #4713 (784238b) into main (78f9195) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4713      +/-   ##
==========================================
- Coverage   64.64%   64.59%   -0.06%     
==========================================
  Files         138      138              
  Lines       23818    23818              
  Branches     4704     4704              
==========================================
- Hits        15398    15386      -12     
- Misses       7220     7231      +11     
- Partials     1200     1201       +1     
Flag Coverage Δ
linux 62.30% <100.00%> (-0.06%) ⬇️
macos 61.79% <100.00%> (+<0.01%) ⬆️
windows 60.61% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xonsh/tools.py 71.56% <100.00%> (ø)
xonsh/jobs.py 44.29% <0.00%> (-3.47%) ⬇️
xonsh/procs/posix.py 70.62% <0.00%> (-0.63%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jnoortheen jnoortheen merged commit b581edb into xonsh:main Mar 14, 2022
@jnoortheen
Copy link
Member

Thanks @yaxollum !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$XONSH_TRACEBACK_LOGFILE with '~' crashes xonsh
3 participants