Use %COMSPEC% not "cmd" to prevent hijacking. Fixes #5254 #5255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning! No news item is found for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5255 +/- ##
==========================================
- Coverage 67.15% 67.12% -0.04%
==========================================
Files 119 119
Lines 23124 23124
Branches 4855 4855
==========================================
- Hits 15530 15522 -8
- Misses 6389 6398 +9
+ Partials 1205 1204 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jnoortheen
approved these changes
Jan 16, 2024
|
This LGTM! any thoughts @anki-code @gforsyth ? |
theadam
pushed a commit
to theadam/xonsh
that referenced
this pull request
Mar 11, 2024
…#5255) * Use %COMSPEC% not "cmd" to prevent hijacking. Fixes xonsh#5254 * Update aliases.py * Update aliases.py --------- Co-authored-by: Andy Kipp <anki-code@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security:
using a malicious "cmd.bat" file in the current directory.
† cls, copy, del, dir, echo, erase, md, mkdir, mklink, move, rd, ren, rename, rmdir, time, type, & vol
#issuenumber 5254