Actually fully disable system clipboard (#5155) #5261
Conversation
azertyfun
force-pushed
the
disable-system-clipboard
branch
2 times, most recently
from
c381fb6
to
3da754a
Compare
|
hi! Thanks you for working on this! |
|
Ah, I see this works only in PTK. No questions. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5261 +/- ##
==========================================
- Coverage 67.16% 65.12% -2.05%
==========================================
Files 119 119
Lines 23124 23099 -25
Branches 4855 4851 -4
==========================================
- Hits 15532 15043 -489
- Misses 6390 6842 +452
- Partials 1202 1214 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I'd suggest adding a separate config variable to control system clipboard integration if there is not one already. This on_delete function controls behaviour of all kill-ring operations |
Fixes xonsh#5155 In VI mode, disabling "delete" hotkeys isn't enough. After discussion in xonsh#5261, we don't change the default behavior but allow fully disabling the system clipboard to better support the use-case of VI mode user.
azertyfun
force-pushed
the
disable-system-clipboard
branch
from
277861d
to
efbdbab
Compare
|
Alright, thanks for the feedback. I've rebased the PR to keep using the old code. There is now no behavior change for users unless they actively set |
Fixes xonsh#5155 In VI mode, disabling "delete" hotkeys isn't enough. After discussion in xonsh#5261, we don't change the default behavior but allow fully disabling the system clipboard to better support the use-case of VI mode user.
azertyfun
force-pushed
the
disable-system-clipboard
branch
from
efbdbab
to
a605074
Compare
|
Thanks @azertyfun ! |
Allow to fully disable system clipboard Fixes xonsh#5155 In VI mode, disabling "delete" hotkeys isn't enough. After discussion in xonsh#5261, we don't change the default behavior but allow fully disabling the system clipboard to better support the use-case of VI mode user. Co-authored-by: Nathan Monfils <nmo@escaux.com>
Fixes #5155
In VI mode, disabling "delete" hotkeys isn't enough.
However not using the
PyperclipClipboardseems like a better solution to the problem anyway (at least to me, maybe I missed something as I am far from a PTK specialist!).The configuration variable has been renamed for consistency, though the old one still works.
For community
⬇️ Please click the 👍 reaction instead of leaving a
+1or 👍 comment