Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention VS Code supports xonsh as default shell #5273

Merged
merged 2 commits into from Feb 5, 2024

Conversation

jaraco
Copy link
Contributor

@jaraco jaraco commented Jan 29, 2024

Ref #4469

Also, updated the text to use 'VS Code', which is the preferred short name.

For community

⬇️ Please click the 👍 reaction instead of leaving a +1 or 👍 comment

@jaraco
Copy link
Contributor Author

jaraco commented Jan 29, 2024

I have tested compiling the file using rst2html.py and this change does not introduce any compilation errors or warnings.

@anki-code
Copy link
Member

Thanks for this! Please add news file to notify the community as well.

Ref xonsh#4469

Also, updated the text to use 'VS Code', which is the preferred short name.
@jaraco
Copy link
Contributor Author

jaraco commented Feb 5, 2024

I've added a news entry. I'd assumed a news entry would not be relevant, as nothing has changed in this version of xonsh... that the entry in the docs is retroactive to older versions of xonsh too, but I've added the entry as directed.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c23508) 67.14% compared to head (75f3333) 67.15%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5273   +/-   ##
=======================================
  Coverage   67.14%   67.15%           
=======================================
  Files         119      119           
  Lines       23125    23125           
  Branches     4855     4855           
=======================================
+ Hits        15528    15529    +1     
+ Misses       6391     6390    -1     
  Partials     1206     1206           
Flag Coverage Δ
macOS-latest 64.45% <ø> (-0.03%) ⬇️
ubuntu-latest 64.73% <ø> (+0.01%) ⬆️
windows-latest 63.09% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anki-code anki-code merged commit 1d54c74 into xonsh:main Feb 5, 2024
15 checks passed
@anki-code
Copy link
Member

Thanks @jaraco !

theadam pushed a commit to theadam/xonsh that referenced this pull request Mar 11, 2024
* Add paragraph about support for xonsh as the default shell.

Ref xonsh#4469

Also, updated the text to use 'VS Code', which is the preferred short name.

* Add news entry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants