Fix parsing of redirect tokens #5322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the parser, wrap redirect tokens such as ">", "a>", and "2>1" in a tuple (along with the name of the redirect file, if applicable) to differentiate them from regular command line arguments. This ensures that a command like ![echo ">"] is parsed correctly. We now need 2 types of IO-redirect tokens (IOREDIRECT1 and IOREDIRECT2) so that the parser knows whether or not an IO-redirect has a file argument. For example, "a>" has type IOREDIRECT1, whereas "2>1" has type IOREDIRECT2.
yaxollum
force-pushed
the
fix-redirect-structure
branch
from
9b6364a
to
8d24617
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5322 +/- ##
==========================================
+ Coverage 67.14% 67.37% +0.22%
==========================================
Files 119 119
Lines 23125 23137 +12
Branches 4855 4860 +5
==========================================
+ Hits 15528 15588 +60
+ Misses 6391 6330 -61
- Partials 1206 1219 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yaxollum
force-pushed
the
fix-redirect-structure
branch
from
8d24617
to
2c10662
Compare
jnoortheen
approved these changes
Apr 5, 2024
|
LGTM, Thanks @yaxollum ! |
|
Hi @yaxollum , I think the following error happens because of the change . I am posting the full traceback with rich tracebacks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2335
This fix changes the parser so that a command like
echo test > a.txt < b.txt o>eis passed like['echo', 'test', ('>', 'a.txt'), ('<', 'b.txt'), ('o>e',)]tocmds_to_specs.Currently, the command is passed like
['echo', 'test', '>', 'a.txt', '<', 'b.txt', 'o>e'], which is what causes the ambiguity between a>redirect token and a">"string literal.For community
⬇️ Please click the 👍 reaction instead of leaving a
+1or 👍 comment