Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert jobs.obj rename #5442

Merged
merged 1 commit into from
May 25, 2024
Merged

Revert jobs.obj rename #5442

merged 1 commit into from
May 25, 2024

Conversation

anki-code
Copy link
Member

@anki-code anki-code commented May 25, 2024

Motivation

Closes #5441

In the nutshell Starship uses "obj" so let's revert the renaming and will implement backwards compatibility when we switch jobs to singleton object some day.

For community

⬇️ Please click the 👍 reaction instead of leaving a +1 or 👍 comment

Copy link

Warning! No news item is found for this PR.
If this is an user facing change/feature/fix, please add a news item by copying the format from news/TEMPLATE.rst.

@anki-code anki-code merged commit 1613914 into main May 25, 2024
12 checks passed
@anki-code
Copy link
Member Author

Thanks @jnoortheen !

@jnoortheen jnoortheen deleted the revert_rename branch May 25, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starship with the current main branch: KeyError: 'obj'
2 participants