fix dotnet 8 breakage in SlowDictionaryAccessor by getting the enumerator through IDictionary instead of IEnumerable #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator through IDictionary instead of IEnumerable
xoofx
force-pushed
the
dictionaryEnumeratorCast
branch
from
a6db1db
to
be77b39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue described in #76
A optimization in dotnet 8 means that we can't assume that the
IEnumerableinterfacesGetEnumeratorwill be the same as the version fromIDictionary. We know that casting toIDictionarywill be safe because this accessor is only used when the object isReflectionObjectKind.Dictionary