address code review feedback

xoofx · Sep 22, 2015 · 556a6ce · 556a6ce
1 parent 71380c8
commit 556a6ce
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/corefx/System.Globalization.Native/localeNumberData.cpp b/src/corefx/System.Globalization.Native/localeNumberData.cpp
@@ -51,7 +51,7 @@ NormalizePattern
 
 Returns a numeric string pattern in a format that we can match against the appropriate managed pattern.
 */
-UnicodeString* NormalizePattern(const UnicodeString *srcPattern, UnicodeString *destPattern, bool isNegative)
+void NormalizePattern(const UnicodeString *srcPattern, UnicodeString *destPattern, bool isNegative)
 {
 	// A srcPattern example: "#,##0.00 C;(#,##0.00 C)" but where C is the international currency symbol (chCurrencySign)
 	// The positive pattern comes first, then an optional negative pattern separated by a semicolon
@@ -80,7 +80,7 @@ UnicodeString* NormalizePattern(const UnicodeString *srcPattern, UnicodeString *
 
 	for (int i = iStart; i <= iEnd; i++)
 	{
-		UChar32 ch = srcPattern->char32At(i);
+		UChar ch = srcPattern->char32At(i);
 		switch (ch)
 		{
 		case chPatternDigit:
@@ -130,8 +130,6 @@ UnicodeString* NormalizePattern(const UnicodeString *srcPattern, UnicodeString *
 	{
 		destPattern->insert(0, chPatternMinus);
 	}
-
-	return destPattern;
 }
 
 /*