Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect setext heading source span #696

Merged
merged 1 commit into from Feb 16, 2023
Merged

Fix incorrect setext heading source span #696

merged 1 commit into from Feb 16, 2023

Conversation

artempyanykh
Copy link
Contributor

Previously, heading's span would be 3-6; where 6 is outside the bounds of the original string.

For the context, the original bug report in Marksman #156 (I use markdig there).

@coveralls
Copy link

coveralls commented Feb 11, 2023

Pull Request Test Coverage Report for Build 4152367422

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 93.293%

Totals Coverage Status
Change from base Build 3993718076: 0.001%
Covered Lines: 25923
Relevant Lines: 27178

💛 - Coveralls

@MihaZupan
Copy link
Collaborator

I'm guessing you didn't want to close this one @artempyanykh :)

@MihaZupan MihaZupan reopened this Feb 11, 2023
@artempyanykh
Copy link
Contributor Author

Haha, no, not really 🙂 Thanks for catching this @MihaZupan!

@xoofx xoofx merged commit 8f8a145 into xoofx:master Feb 16, 2023
@xoofx
Copy link
Owner

xoofx commented Feb 16, 2023

Thanks!

@xoofx xoofx added the bug label Feb 27, 2023
@artempyanykh artempyanykh deleted the fix-setext-span branch April 2, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants