Merge pull request #24 from Rohansi/add-canwatchimpls

Add CanWatch impls to physical and composite FS
xoofx · Jan 12, 2018 · 1e11cf5 · 1e11cf5
2 parents 8b6efb5 + 67583e5
commit 1e11cf5
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 0 deletions.
diff --git a/src/Zio/FileSystems/AggregateFileSystem.cs b/src/Zio/FileSystems/AggregateFileSystem.cs
@@ -406,6 +406,13 @@ protected override UPath ConvertPathFromDelegate(UPath path)
         // Watch API
         // ----------------------------------------------
 
+        /// <inheritdoc />
+        protected override bool CanWatchImpl(UPath path)
+        {
+            // Always allow watching because a future filesystem can be added that matches this path.
+            return true;
+        }
+
         /// <inheritdoc />
         protected override IFileSystemWatcher WatchImpl(UPath path)
         {

diff --git a/src/Zio/FileSystems/ComposeFileSystem.cs b/src/Zio/FileSystems/ComposeFileSystem.cs
@@ -197,6 +197,12 @@ protected override IEnumerable<UPath> EnumeratePathsImpl(UPath path, string sear
         // ----------------------------------------------
         // Watch API
         // ----------------------------------------------
+
+        /// <inheritdoc />
+        protected override bool CanWatchImpl(UPath path)
+        {
+            return NextFileSystemSafe.CanWatch(ConvertPathToDelegate(path));
+        }
 
         /// <inheritdoc />
         protected override IFileSystemWatcher WatchImpl(UPath path)

diff --git a/src/Zio/FileSystems/MountFileSystem.cs b/src/Zio/FileSystems/MountFileSystem.cs
@@ -627,6 +627,13 @@ IEnumerable<UPath> EnumeratePathFromFileSystem(UPath subPath, bool failOnInvalid
             }
         }
 
+        /// <inheritdoc />
+        protected override bool CanWatchImpl(UPath path)
+        {
+            // Always allow watching because a future filesystem can be added that matches this path.
+            return true;
+        }
+
         /// <inheritdoc />
         protected override IFileSystemWatcher WatchImpl(UPath path)
         {

diff --git a/src/Zio/FileSystems/PhysicalFileSystem.cs b/src/Zio/FileSystems/PhysicalFileSystem.cs
@@ -510,6 +510,17 @@ protected override IEnumerable<UPath> EnumeratePathsImpl(UPath path, string sear
         // ----------------------------------------------
         // Watch API
         // ----------------------------------------------
+
+        /// <inheritdoc />
+        protected override bool CanWatchImpl(UPath path)
+        {
+            if (IsWithinSpecialDirectory(path))
+            {
+                return SpecialDirectoryExists(path);
+            }
+
+            return Directory.Exists(ConvertPathToInternal(path));
+        }
 
         /// <inheritdoc />
         protected override IFileSystemWatcher WatchImpl(UPath path)