Fix bug on SubFileSystem.ConvertPathToDelegate

[dohki]

It just prepends root path to the relative path without considering current working directory.

zio/src/Zio/FileSystems/SubFileSystem.cs

Line 68 in d245c2c

return SubPath / safePath;

Can you implement this two features?

1. Add member for current working directory to SubFileSystem
2. Add method for changing the member mentioned in 1.

Thank you.

[xoofx]

PR welcome.

[xoofx]

path without considering current working directory.

Actually I don't understand the issue. Can you elaborate? What is a current directory in a sub file system?

[dohki]

zio/src/Zio/FileSystems/SubFileSystem.cs

Lines 65 to 69 in d245c2c

	protected override UPath ConvertPathToDelegate(UPath path)
	{
	var safePath = path.ToRelative();
	return SubPath / safePath;
	}

This implementation is fine when path is absolute. The problem happens when path is relative because it doesn't consider the current working directory. path.ToRelative won't affect relative path since itself is already an relative path and the result safePath will be directly appended to SubPath as if it were an absolute path.

[xoofx]

Again, I don't understand, there is no concept of current directory in Zio. SubPath is supposed to be an absolute folder. Could you give an example with what you are trying to do?

[dohki]

Relative path is literally the path relative to the current working directory.
But, it seems Zio works like as if current working directory is root (e.g. /) as you said.

zio/src/Zio/UPathExtensions.cs

Lines 40 to 50 in 8026d37

	public static UPath ToAbsolute(this UPath path)
	{
	path.AssertNotNull();
	if (path.IsAbsolute)
	{
	return path;
	}
	return path.IsEmpty ? UPath.Root : UPath.Root / path;
	}

Then, I'll be sure to pass only absolute path to ConvertPathToDelegate after prepending current working directory on relative path case if you don't want to introduce current working directory concept.

[xoofx]

if you don't want to introduce current working directory concept.

It can't. A current working directory is only relevant for a system wide current directory. In Zio, you can have multiple filesystems in // that don't share anything. So a current directory has no meaning.

Zio works only with absolute paths when accessing a filesystems.