Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more tests in testlogger & renaming receivers. #36

Merged
merged 4 commits into from
Aug 25, 2022

Conversation

miccagiann
Copy link
Collaborator

@miccagiann miccagiann commented Aug 24, 2022

I have renamed the receivers in testlogger.zzzgo file. I have added more tests to cover the missing methods for testlogger. I have completed 100% coverage for support.go file... Still I am wrapping my head on how to test only the methods for seed.go, span.go and config.go.

@miccagiann miccagiann requested a review from muir August 24, 2022 16:17
Copy link
Collaborator

@muir muir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs at least one little fix before merging. The numbering for -1 isn't important enough to worry about.

support_test.go Show resolved Hide resolved
xoptest/testlogger_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #36 (6886dde) into main (2f07ad9) will increase coverage by 0.75%.
The diff coverage is 95.91%.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   40.28%   41.03%   +0.75%     
==========================================
  Files          36       36              
  Lines        3197     3197              
==========================================
+ Hits         1288     1312      +24     
+ Misses       1845     1823      -22     
+ Partials       64       62       -2     
Flag Coverage Δ
go_tests 41.03% <95.91%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xopjson/attributes.go 18.13% <0.00%> (ø)
xoptest/testlogger.go 51.54% <96.70%> (+0.51%) ⬆️
xoptest/filter.go 100.00% <100.00%> (ø)
support.go 100.00% <0.00%> (+27.27%) ⬆️
config.go 86.36% <0.00%> (+86.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@miccagiann miccagiann merged commit f35ac8c into main Aug 25, 2022
@miccagiann miccagiann deleted the test-increase-coverage branch August 25, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants