Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs with non-detached sub-spans #49

Merged
merged 1 commit into from
Sep 4, 2022
Merged

fix bugs with non-detached sub-spans #49

merged 1 commit into from
Sep 4, 2022

Conversation

muir
Copy link
Collaborator

@muir muir commented Sep 4, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Base: 55.83% // Head: 57.12% // Increases project coverage by +1.28% 🎉

Coverage data is based on head (5d91f21) compared to base (a85d0d0).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   55.83%   57.12%   +1.28%     
==========================================
  Files          37       37              
  Lines        3485     3515      +30     
==========================================
+ Hits         1946     2008      +62     
+ Misses       1466     1431      -35     
- Partials       73       76       +3     
Flag Coverage Δ
go_tests 57.12% <80.00%> (+1.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
logger.go 78.61% <79.59%> (+7.19%) ⬆️
not_testing.go 100.00% <100.00%> (ø)
xoptest/testlogger.go 63.24% <0.00%> (+0.17%) ⬆️
xopjson/jsonlogger.go 67.82% <0.00%> (+0.19%) ⬆️
base.go 81.81% <0.00%> (+27.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@muir muir merged commit 30394d5 into main Sep 4, 2022
@muir muir deleted the thirtynine branch September 4, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants