Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing #68

Merged
merged 4 commits into from
Sep 25, 2022
Merged

Polishing #68

merged 4 commits into from
Sep 25, 2022

Conversation

muir
Copy link
Collaborator

@muir muir commented Sep 24, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2022

Codecov Report

Base: 85.03% // Head: 84.20% // Decreases project coverage by -0.83% ⚠️

Coverage data is based on head (480fe83) compared to base (bec82ef).
Patch coverage: 46.32% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   85.03%   84.20%   -0.84%     
==========================================
  Files          42       42              
  Lines        4779     4861      +82     
==========================================
+ Hits         4064     4093      +29     
- Misses        629      675      +46     
- Partials       86       93       +7     
Flag Coverage Δ
go_tests 84.20% <46.32%> (-0.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
basegroup.go 90.09% <0.00%> (-2.08%) ⬇️
config.go 86.36% <ø> (ø)
sub.go 95.41% <ø> (ø)
xopjson/models.go 68.18% <ø> (+5.68%) ⬆️
xoptest/xoptestutil/enums.go 80.00% <ø> (ø)
xopjson/jsonlogger.go 75.77% <13.79%> (-1.32%) ⬇️
line.go 63.44% <16.21%> (-31.39%) ⬇️
xoptest/testlogger.go 98.10% <69.23%> (-0.67%) ⬇️
logger.go 88.37% <73.33%> (-1.00%) ⬇️
xopotel/otel.go 81.26% <89.18%> (+0.21%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@muir muir merged commit 77cc952 into main Sep 25, 2022
@muir muir deleted the fiftysix branch September 25, 2022 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants