Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xopbase.Logger.Close removed #69

Merged
merged 1 commit into from
Sep 25, 2022
Merged

xopbase.Logger.Close removed #69

merged 1 commit into from
Sep 25, 2022

Conversation

muir
Copy link
Collaborator

@muir muir commented Sep 25, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Base: 84.15% // Head: 84.39% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (320d696) compared to base (77cc952).
Patch coverage: 81.81% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   84.15%   84.39%   +0.23%     
==========================================
  Files          42       42              
  Lines        4861     4850      -11     
==========================================
+ Hits         4091     4093       +2     
+ Misses        677      664      -13     
  Partials       93       93              
Flag Coverage Δ
go_tests 84.39% <81.81%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xopjson/models.go 68.18% <ø> (ø)
xopotel/otel.go 81.40% <ø> (+0.14%) ⬆️
xoptest/testlogger.go 98.09% <ø> (-0.01%) ⬇️
xopjson/jsonlogger.go 77.31% <81.81%> (+1.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@muir muir merged commit 8ede7c4 into main Sep 25, 2022
@muir muir deleted the fiftyseven branch September 25, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants