Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Bundle.ParentTrace -> Bundle.Parent #86

Merged
merged 3 commits into from
Oct 4, 2022
Merged

rename Bundle.ParentTrace -> Bundle.Parent #86

merged 3 commits into from
Oct 4, 2022

Conversation

muir
Copy link
Collaborator

@muir muir commented Oct 4, 2022

Also: increase test coverage some
And: note we're slower than Zerolog at the moment.

@codecov-commenter
Copy link

Codecov Report

Base: 86.23% // Head: 86.63% // Increases project coverage by +0.40% 🎉

Coverage data is based on head (6e2220f) compared to base (a8a4006).
Patch coverage: 87.93% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   86.23%   86.63%   +0.40%     
==========================================
  Files          45       45              
  Lines        5195     5216      +21     
==========================================
+ Hits         4480     4519      +39     
+ Misses        609      594      -15     
+ Partials      106      103       -3     
Flag Coverage Δ
go_tests 86.63% <87.93%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
span.go 84.74% <0.00%> (ø)
xopjson/models.go 68.18% <ø> (ø)
xopotel/otel.go 85.50% <0.00%> (ø)
xopmiddle/middleware.go 91.13% <66.66%> (ø)
xopmiddle/utils.go 58.97% <66.66%> (ø)
xopjson/jsonlogger.go 79.04% <94.11%> (+2.84%) ⬆️
logger.go 88.40% <100.00%> (ø)
trace/bundle.go 100.00% <100.00%> (ø)
xoptest/xoptestutil/cases.go 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@muir muir merged commit 6964c2a into main Oct 4, 2022
@muir muir deleted the seventyfour branch October 4, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants