Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xopjson no longer buffers internally; xopbytes has a richer API #87

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

muir
Copy link
Collaborator

@muir muir commented Oct 13, 2022

xopjson no longer buffers internally.

xopbytes has a richer API.

Incompatible changes:

  • xopjson no longer supports WithBufferedLines()

  • xopbytes.BytesWriter interface has additional and changed methods

    xopbytes.WriteToIOWriter() is unchanged

xopbytes has a richer API.

Incompatible changes:

- xopjson no longer supports WithBufferedLines()
- xopbytes.BytesWriter interface has additional and changed methods

  xopbytes.WriteToIOWriter() is unchanged
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Base: 86.67% // Head: 87.13% // Increases project coverage by +0.46% 🎉

Coverage data is based on head (7d05ffc) compared to base (6964c2a).
Patch coverage: 55.81% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   86.67%   87.13%   +0.46%     
==========================================
  Files          45       45              
  Lines        5216     5124      -92     
==========================================
- Hits         4521     4465      -56     
+ Misses        592      564      -28     
+ Partials      103       95       -8     
Flag Coverage Δ
go_tests 87.13% <55.81%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xopat/attributes.go 46.29% <0.00%> (-0.44%) ⬇️
xopjson/models.go 68.42% <ø> (+0.23%) ⬆️
xopjson/jsonlogger.go 84.07% <48.14%> (+4.63%) ⬆️
xopbytes/iowriter.go 65.21% <73.33%> (+1.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@muir muir merged commit e5a638c into main Oct 13, 2022
@muir muir deleted the seventyfive branch October 13, 2022 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants