Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: xoptest #93

Merged
merged 11 commits into from
Apr 10, 2023
Merged

BREAKING CHANGE: xoptest #93

merged 11 commits into from
Apr 10, 2023

Conversation

muir
Copy link
Collaborator

@muir muir commented Apr 10, 2023

This change decomposes xoptest into xoprecorder and xopcon. This is a breaking change because the xoptest APIs change. The functionality remains the same.

@muir muir marked this pull request as ready for review April 10, 2023 01:12
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 90.29% and project coverage change: +0.18 🎉

Comparison is base (0d7303e) 77.50% compared to head (33eca79) 77.68%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   77.50%   77.68%   +0.18%     
==========================================
  Files          61       65       +4     
  Lines        9177     9489     +312     
==========================================
+ Hits         7113     7372     +259     
- Misses       1711     1743      +32     
- Partials      353      374      +21     
Flag Coverage Δ
go_tests 77.68% <90.29%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config.go 86.36% <ø> (ø)
xoprecorder/eventtype_enumer.go 95.52% <ø> (ø)
xoprecorder/filter.go 61.53% <50.00%> (ø)
xoptrace/trace.go 79.68% <66.66%> (+0.65%) ⬆️
xoputil/counter.go 72.50% <72.50%> (ø)
xopcon/console.go 82.22% <82.22%> (ø)
xopbase/xopbaseutil/metadata.go 90.78% <90.78%> (ø)
xoprecorder/recorder.go 95.32% <95.32%> (ø)
xoptest/xoptestutil/verify_replay.go 92.52% <95.65%> (-1.08%) ⬇️
basegroup.go 91.41% <100.00%> (+7.20%) ⬆️
... and 5 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@muir muir merged commit 8c7d904 into main Apr 10, 2023
11 checks passed
@muir muir deleted the recorder branch April 10, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants