Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: xoppb replay API #94

Merged
merged 1 commit into from
Apr 23, 2023
Merged

refactor: xoppb replay API #94

merged 1 commit into from
Apr 23, 2023

Conversation

muir
Copy link
Collaborator

@muir muir commented Apr 23, 2023

This is a very minor breaking change to replay in xoppb

@muir muir marked this pull request as ready for review April 23, 2023 04:53
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (f67e104) 76.47% compared to head (f4a1bf5) 76.51%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   76.47%   76.51%   +0.03%     
==========================================
  Files          63       63              
  Lines        9416     9410       -6     
==========================================
- Hits         7201     7200       -1     
+ Misses       1816     1812       -4     
+ Partials      399      398       -1     
Flag Coverage Δ
go_tests 76.51% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xoppb/replay.go 76.51% <100.00%> (+1.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@muir muir merged commit 6d6ace3 into main Apr 23, 2023
11 checks passed
@muir muir deleted the pbReplay branch April 23, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants