Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking change: use a key type #95

Merged
merged 2 commits into from
Dec 30, 2023
Merged

breaking change: use a key type #95

merged 2 commits into from
Dec 30, 2023

Conversation

muir
Copy link
Collaborator

@muir muir commented Apr 23, 2023

Changes the key type for attributes to be a typed string.
Adds a cache of JSON encodings for the keys.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2023

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (a5ad1de) 76.99% compared to head (20b9966) 76.96%.

Files Patch % Lines
xopotel/export.go 63.46% 19 Missing ⚠️
xopotel/otel.go 88.59% 13 Missing ⚠️
xopbase/skip.go 0.00% 9 Missing ⚠️
xoppb/replay.go 88.05% 6 Missing and 2 partials ⚠️
xopconsole/replay.go 75.00% 4 Missing ⚠️
xopotel/buffered.go 60.00% 2 Missing ⚠️
xoprecorder/replay.go 95.65% 1 Missing ⚠️
xopresty/resty.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   76.99%   76.96%   -0.03%     
==========================================
  Files          68       69       +1     
  Lines       11204    11233      +29     
==========================================
+ Hits         8627     8646      +19     
- Misses       2061     2072      +11     
+ Partials      516      515       -1     
Flag Coverage Δ
go_tests 76.96% <89.20%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

use "type K string" instead of a struct
@muir muir merged commit aa1b1fd into main Dec 30, 2023
12 of 13 checks passed
@muir muir deleted the key branch December 30, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants