Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Increase validator types for thie 'input' parameter of embeddings to match OpenAI API #1201

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

Minamiyama
Copy link
Contributor

image

@XprobeBot XprobeBot added this to the v0.9.5 milestone Mar 27, 2024
@Minamiyama Minamiyama changed the title increase validator types for thie 'input' parameter of embeddings mat… BUG: Increase validator types for thie 'input' parameter of embeddings mat… Mar 27, 2024
@XprobeBot XprobeBot added the bug Something isn't working label Mar 27, 2024
@qinxuye
Copy link
Contributor

qinxuye commented Mar 28, 2024

Lint failed, could you fix it?

@Minamiyama Minamiyama changed the title BUG: Increase validator types for thie 'input' parameter of embeddings mat… BUG: Increase validator types for thie 'input' parameter of embeddings to match OpenAI API Mar 28, 2024
@Minamiyama
Copy link
Contributor Author

Lint failed, could you fix it?

I have no idea where the problem is.

@qinxuye
Copy link
Contributor

qinxuye commented Mar 28, 2024

See https://github.com/xorbitsai/inference/actions/runs/8460003388/job/23177384826?pr=1201

You may need to install black and use it to format your code.

@Minamiyama
Copy link
Contributor Author

See https://github.com/xorbitsai/inference/actions/runs/8460003388/job/23177384826?pr=1201

You may need to install black and use it to format your code.

done

Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye
Copy link
Contributor

qinxuye commented Mar 28, 2024

Have you tried if it works?

@Minamiyama
Copy link
Contributor Author

Have you tried if it works?

yes, of cos. it caused a problem for me, fixed it and solved the problem

@qinxuye qinxuye merged commit 5a83dd5 into xorbitsai:main Mar 28, 2024
7 of 12 checks passed
qinxuye pushed a commit to qinxuye/inference that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants