FEAT: ChatGLM3 tool calls #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
What is the error message? Did you test function calling on this branch? |
yes, i merge your branch and test it
it seems tool is a empty slice, not null |
|
@waltcow how did you call? Using python client or jusr via RESTful api? |
|
I didn't reproduce it, could you check your openai version? it needs to later than v1.0 |
(infer) ➜ inference git:(tool) pip show openai |
|
@waltcow thanks for your feedback, I've reproduced it, this issue happens with pytorch format, and we will fix it in this PR. |
it works now, thanks |
ChengjieLi28
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support tool calls for ChatGLM3, but the response function arguments are different:
Post URL:
http://localhost:42183/v1/chat/completionspayload json:
{ "model": "test_tool", "messages": [ { "role": "user", "content": "帮我查询股票10111的价格" } ], "tools": [ { "type": "function", "function": { "name": "track", "description": "追踪指定股票的实时价格", "parameters": { "type": "object", "properties": { "symbol": { "description": "需要追踪的股票代码" } }, "required": [ "symbol" ] } } }, { "type": "function", "function": { "name": "text-to-speech", "description": "将文本转换为语音", "parameters": { "type": "object", "properties": { "text": { "description": "需要转换成语音的文本" }, "voice": { "description": "要使用的语音类型（男声、女声等）" }, "speed": { "description": "语音的速度（快、中等、慢等）" } }, "required": [ "text" ] } } } ], "stop": [ "\n" ] }ChatGLM3 response (The arguments is a json string):
{ "id": "chatcmpl-095b7d07-74ed-44aa-9405-a3a999f73ebf", "model": "test_tool", "object": "chat.completion", "created": 1701339681, "choices": [ { "index": 0, "message": { "role": "assistant", "content": null, "tool_calls": [ { "id": "call_095b7d07-74ed-44aa-9405-a3a999f73ebf", "type": "function", "function": { "name": "track", "arguments": "{\"symbol\": \"10111\"}" } } ] }, "finish_reason": "tool_calls" } ], "usage": { "prompt_tokens": -1, "completion_tokens": -1, "total_tokens": -1 } }ChatGLM: https://github.com/THUDM/ChatGLM3/blob/main/tool_using/README.md
ChatGLM cpp: https://github.com/li-plus/chatglm.cpp/blob/main/examples/chatglm3_demo.py
Closes: #676