Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: upgrade insecure requests when necessary #712

Merged
merged 1 commit into from
Dec 4, 2023
Merged

ENH: upgrade insecure requests when necessary #712

merged 1 commit into from
Dec 4, 2023

Conversation

waltcow
Copy link
Contributor

@waltcow waltcow commented Dec 4, 2023 •
edited
Loading

fix #639

@XprobeBot XprobeBot added this to the v0.6.6 milestone Dec 4, 2023
@ChengjieLi28
Copy link
Contributor

Hi, @waltcow . Could you please clarify here what problem this PR is solving? And then please attach some screenshots to prove it, thank you.

@ChengjieLi28 ChengjieLi28 changed the title upgrade insecure requests when necessary ENH: upgrade insecure requests when necessary Dec 4, 2023
@XprobeBot XprobeBot added the enhancement New feature or request label Dec 4, 2023
@waltcow
Copy link
Contributor Author

waltcow commented Dec 4, 2023

I try to use nginx forward port to local dev sever via https schema.
but when i open frontend ui, the console log show that

image

@ChengjieLi28
Copy link
Contributor

I try to use nginx forward port to local dev sever via https schema. but when i open frontend ui, the console log show that

image

Great fix. Thank you very much.

@ChengjieLi28 ChengjieLi28 merged commit 9a52f78 into xorbitsai:main Dec 4, 2023
11 of 12 checks passed
qinxuye added a commit that referenced this pull request Dec 4, 2023
@qinxuye
Revert "ENH: upgrade insecure requests when necessary (#712)"
becbc59 
This reverts commit 9a52f78.
@qinxuye qinxuye mentioned this pull request Dec 4, 2023
Merged
@ChengjieLi28 ChengjieLi28 mentioned this pull request Dec 5, 2023
Closed
@ChengjieLi28
Copy link
Contributor

Hi, @waltcow .
We have reverted your PR #712 since if there is only http service, the UI would enconter an error.
Could you please test #722 in your environment to verify whether it is worked? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChengjieLi28 ChengjieLi28 ChengjieLi28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

BUG: model is launched but can not find any items in UI
3 participants
@waltcow @ChengjieLi28 @XprobeBot