FEAT: Refactor device related code and add initial Intel GPU support #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notsyncing
force-pushed
the
intel-gpu-support
branch
2 times, most recently
from
19332e9
to
f7b70f9
Compare
|
Wow, impressive work! |
|
Lint failed, we use pre-commit(https://pre-commit.com/) to lint before commit, you can install it on local and commit again. |
notsyncing
force-pushed
the
intel-gpu-support
branch
from
f7b70f9
to
d034b3b
Compare
|
@aresnow1 All lint errors fixed, and tested again on chatglm3. |
qinxuye
force-pushed
the
intel-gpu-support
branch
from
07e1c5b
to
e91a643
Compare
|
I solved the lint for you, other than flake8, we use black to format code and isort to sort the imports. |
aresnow1
reviewed
Feb 5, 2024
notsyncing
force-pushed
the
intel-gpu-support
branch
3 times, most recently
from
3a9ceb9
to
88f2214
Compare
notsyncing
force-pushed
the
intel-gpu-support
branch
2 times, most recently
from
88f0935
to
7dafcf1
Compare
|
Hi, could you rebase main branch and push again? |
notsyncing
force-pushed
the
intel-gpu-support
branch
from
7dafcf1
to
2278ac0
Compare
Rebased and pushed. |
aresnow1
approved these changes
Feb 21, 2024
|
Looks good to me, thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors most device related code into
device_utils(onlypytorchbackend,vllmandctransformersare unsupported,8bitand4bitare also unsupported), and adds initial Intel GPU support.You will need
intel-extension-for-pytorchto run it: https://intel.github.io/intel-extension-for-pytorch/xpu/latest/tutorials/installation.htmlTested on Llama2-chat and ChatGlm3.
(for
device_map, requires huggingface/accelerate#2383)