Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Automatically install some version-sensitive packages and select image for user #192

Merged

Conversation

ChengjieLi28
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #191
Fixes #156

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Feb 6, 2023
@XprobeBot XprobeBot added this to the v0.2.0 milestone Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #192 (679c4f5) into main (2c8d9e5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 679c4f5 differs from pull request most recent head 3aabaa0. Consider uploading reports for the commit 3aabaa0 to get more accurate results

@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
- Coverage   99.36%   99.36%   -0.01%     
==========================================
  Files          30       32       +2     
  Lines        1107     1094      -13     
  Branches      188      185       -3     
==========================================
- Hits         1100     1087      -13     
  Misses          2        2              
  Partials        5        5              
Flag Coverage Δ
unittests 99.36% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xorbits/compat/_constants.py 100.00% <100.00%> (ø)
python/xorbits/deploy/kubernetes/_constants.py 100.00% <100.00%> (ø)
python/xorbits/core/execution.py 94.11% <0.00%> (-2.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ChengjieLi28 ChengjieLi28 force-pushed the enh/handle_sensitive_version branch 3 times, most recently from 66d0355 to 304e101 Compare February 14, 2023 08:05
Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qianduoduo0904 qianduoduo0904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qianduoduo0904 qianduoduo0904 merged commit aee883b into xorbitsai:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants