Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add test_put_get_arrow #656

Merged
merged 3 commits into from Aug 21, 2023

Conversation

codingl2k1
Copy link
Contributor

@codingl2k1 codingl2k1 commented Aug 14, 2023

What do these changes do?

Related issue number

Fixes #638
#661

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the testing Testing functions or related to the test suite label Aug 14, 2023
@XprobeBot XprobeBot added this to the v0.5.2 milestone Aug 14, 2023
@codingl2k1 codingl2k1 marked this pull request as ready for review August 14, 2023 10:48
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #656 (659b8a3) into main (4d79be2) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #656   +/-   ##
=======================================
  Coverage   93.57%   93.57%           
=======================================
  Files        1025     1025           
  Lines       79726    79726           
  Branches    16535    16535           
=======================================
+ Hits        74602    74604    +2     
+ Misses       3447     3440    -7     
- Partials     1677     1682    +5     
Flag Coverage Δ
unittests 93.47% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit 4855622 into xorbitsai:main Aug 21, 2023
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: ValueError: memoryview assignment: lvalue and rvalue have different structures
4 participants