GUI: Don't deref sound items before nullptr checking

This fixes Coverity Scan issue #218995.
xoreos · Jul 27, 2019 · f07d2ab · f07d2ab
1 parent 871142b
commit f07d2ab
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/gui/panelpreviewsound.cpp b/src/gui/panelpreviewsound.cpp
@@ -102,17 +102,13 @@ void PanelPreviewSound::show(const ResourceTreeItem *item) {
 	PanelBase::show(item);
 
 	stop();
+	_currentItem = nullptr;
+	_duration = Sound::RewindableAudioStream::kInvalidLength;
 
-	if (item->getResourceType() != Aurora::kResourceSound)
+	if (!item || (item->getResourceType() != Aurora::kResourceSound))
 		return;
 
 	_currentItem = item;
-
-	if (!item) {
-		_duration = Sound::RewindableAudioStream::kInvalidLength;
-		return;
-	}
-
 	_duration = item->getSoundDuration();
 }