Skip to content

Commit

Permalink
BUILD: Disable the -Winconsistent-missing-override compiler warning
Browse files Browse the repository at this point in the history
We are currently inconsistent.
  • Loading branch information
DrMcCoy committed Sep 21, 2019
1 parent 41419b9 commit 2a980dc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ if (NOT "${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")

# clang is far too trigger-happy on this warning, so let's disable it
set_check_compiler_flag_cxx("-Wundefined-var-template" "-Wno-undefined-var-template")

# We do not yet mark any of our overrides. Let's disable this for now
set_check_compiler_flag_cxx("-Winconsistent-missing-override" "-Wno-inconsistent-missing-override")
endif()

# platform specific warning settings
Expand Down
3 changes: 3 additions & 0 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,9 @@ AX_CHECK_COMPILER_FLAGS_VAR([C++], [WARN], [-Wc++11-long-long], [-Wno-c++11-long
dnl clang is far too trigger-happy on this warning, so let's disable it
AX_CHECK_COMPILER_FLAGS_VAR([C++], [WARN], [-Wundefined-var-template], [-Wno-undefined-var-template])

dnl We do not yet mark any of our overrides. Let's disable this for now
AX_CHECK_COMPILER_FLAGS_VAR([C++], [WARN], [-Winconsistent-missing-override], [-Wno-inconsistent-missing-override])

AC_SUBST(WARN)

dnl C++ dialect
Expand Down

0 comments on commit 2a980dc

Please sign in to comment.