COMMON: Remove empty user-provided destructors

Because implicit copy constructors and assignment operators with user-provided destructors are deprecated in C++11.
xoreos · May 5, 2019 · bd8bad1 · bd8bad1
1 parent b185a76
commit bd8bad1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/src/common/error.cpp b/src/common/error.cpp
@@ -31,9 +31,6 @@
 
 namespace Common {
 
-StackException::StackException() {
-}
-
 StackException::StackException(const char *s, ...) {
 	char buf[STRINGBUFLEN];
 	va_list va;
@@ -45,16 +42,10 @@ StackException::StackException(const char *s, ...) {
 	_stack.push(buf);
 }
 
-StackException::StackException(const StackException &e) : _stack(e._stack) {
-}
-
 StackException::StackException(const std::exception &e) {
 	add(e);
 }
 
-StackException::~StackException() throw() {
-}
-
 void StackException::add(const char *s, ...) {
 	char buf[STRINGBUFLEN];
 	va_list va;

diff --git a/src/common/error.h b/src/common/error.h
@@ -37,11 +37,11 @@ class StackException : public std::exception {
 public:
 	typedef std::stack<UString> Stack;
 
-	StackException();
+	StackException() = default;
 	StackException(const char *s, ...) GCC_PRINTF(2, 3);
-	StackException(const StackException &e);
+	StackException(const StackException &e) = default;
 	StackException(const std::exception &e);
-	~StackException() throw();
+	~StackException() = default;
 
 	void add(const char *s, ...) GCC_PRINTF(2, 3);
 	void add(const std::exception &e);