Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMAGES: Fix TPC TXI reading in multi mipmap images #44

Closed
wants to merge 2 commits into from

Conversation

Nostritius
Copy link
Contributor

My second try for fixing the tpc problem #42

@DrMcCoy
Copy link
Member

DrMcCoy commented Jun 9, 2019

Yeah, this is better (it works for C_Wraid02.tpc), but it still fails for KotOR2's 002_EBO_Inside4b.tpc, for example.

It now seems to work for TPC that don't contain TXI data, but fails for (non-animated?) TPC that do have TXI data, including all the cubemaps (CM_*).

@DrMcCoy
Copy link
Member

DrMcCoy commented Jun 9, 2019

(For testing, I just extracted swpc_tex_gui.erf and swpc_tex_tpa.erf in the texturepacks directory and ran

for i in *.tpc; do echo "$i"; xoreostex2tga "$i" "$i.tga"; done

over it. I also have a build from before ecfb314, i.e. the direct parent 9007c52, and can just see where it fails with the newer build.)

@Nostritius
Copy link
Contributor Author

Ok, now most of the images should once more be readable. There are a few exceptions, but they were not readable even before.

@DrMcCoy
Copy link
Member

DrMcCoy commented Jun 10, 2019

Yes, seems to work completely again now, thanks! :)

Merged as 34649c0...9c1d845. I also added a commits that change some TXI option types to float (among them "fps"), so a few more files work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants