-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch filtering doesn't work as expected #166
Comments
Yeah, I can tell you right off the bat, that I've never heard of this feature before your ticket 😉 |
I can't find your Did they remove it and possibly replace it with |
You can try this link:
https://github.com/EncoreTechnologies/r10k/blob/feature/branch-filtering/doc/dynamic-environments/configuration.mkd#filter-branches---match-branches-exactly
Works for me in incognito mode as well.
…On Thu, Jul 23, 2020 at 1:24 PM Andreas Paul ***@***.***> wrote:
I can't find your branch_filter setting in the official r10k
documentation anymore.
Did they remove it and possibly replace it with filter_command?
https://github.com/puppetlabs/r10k/blob/master/doc/dynamic-environments/configuration.mkd#filter_command
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#166 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJRBWDWUP6TCGXIP7TGPDFTR5AMYNANCNFSM4PEYBHCA>
.
|
Yeah, I saw this link, but that is a fork of the official r10k repository in a branch that is multiple years old. I would rather implement the This would seem to achieve the same result you expect:
or
Right? You can also simply test it in your shell:
|
…ipBasedOnFilterRegex for source setting filter_regex, fixes #166
Checkout my examples here: #167 Would that work for you? I could not get the previous filter commands to work as I would need to reimplement the Bash piping or shell keywords like I can still rename the |
Thanks Andreas,
Will check this out and get back to you.
…On Tue, 28 Jul 2020, 18:40 Andreas Paul, ***@***.***> wrote:
Checkout my examples here: #167 <#167>
Would that work for you?
I could not get the previous filter commands to work as I would need to
reimplement the Bash piping or shell keywords like [[, but you could use
a simple bash wrapper script for this like
https://github.com/xorpaul/g10k/blob/add_branch_filtering/tests/branch_filter_command.sh
I can still rename the filter_regex to the branch_filter settings name.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#166 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJRBWDXETLWYN55COFRPHILR535QLANCNFSM4PEYBHCA>
.
|
I've added the branch filtering stuff to the new release here: |
Hello,
Branch filtering within the g10k config file doesn't work as expected:
Using this for reference:
https://github.com/EncoreTechnologies/r10k/blob/feature/branch-filtering/doc/dynamic-environments/configuration.mkd
g10k Config File
This would threotically pull only the
develop
branch but it ends up pulling everything.I can get it to work as expected if I pass the
--branch develop
parameter with the g10k command.I unfortunately need this functionality to work since I use multiple branches in one Puppet environment.
The text was updated successfully, but these errors were encountered: