Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future Ideas Board #33

Open
xosadmin opened this issue Apr 27, 2024 · 15 comments
Open

Future Ideas Board #33

xosadmin opened this issue Apr 27, 2024 · 15 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@xosadmin
Copy link
Owner

xosadmin commented Apr 27, 2024

Here are some ideas for future versions:

  • User Level System
  • Allow User use owned item to pay for rewards
  • Personal Bio
  • Implement User Name
  • Add search filters

Any ideas or thoughts? Please post here.

@xosadmin xosadmin added the documentation Improvements or additions to documentation label Apr 27, 2024
@xosadmin xosadmin changed the title Future Ideas Future Ideas Board Apr 27, 2024
@Phyo09
Copy link
Collaborator

Phyo09 commented May 6, 2024

Registration Errors

  1. Different password is working for Repeat password (Solved)
  2. Include AJAX so then users do not need to know its different repeat password without clicking "Register." (Solved)
  3. Include AJAX for password and PIN Code as well, user can know the error without clicking "Register" (Solved)
  4. is PIN numeric or alpha-numeric? Cannot be letters only (Solved)

Summary
Validation is not working properly. The definition of PIN code is incorrect.

Edited
Validation is working now. User can see detailed error after clicking "Register".
Definition of PIN code is not clear enough on webpage yet.

@Phyo09
Copy link
Collaborator

Phyo09 commented May 6, 2024

Login Error

  1. Can go to login page when I have logged in. Shouldn't the page show that the user has already logged in or redirect to Home/Profile page? (Solved)

@Phyo09
Copy link
Collaborator

Phyo09 commented May 6, 2024

Forgot Password Page Error

  1. Login button on navi is not working. (Solved)
  2. The text "Forget your password? No panic! Let we help you!" is left-align. (Solved)

@Phyo09
Copy link
Collaborator

Phyo09 commented May 6, 2024

Password on Profile page,

  1. Why i cannot see the current password on profile page? Can we use hide function instead? (Solved)
  2. When changing password, why i need to provide PIN code? I am not changing my PIN code. I put the new one in, but the PIN code never changed. What is the purpose of PIN code here? (Solved)

@xosadmin
Copy link
Owner Author

xosadmin commented May 7, 2024

  1. The problem regarding repeat passwords has been resolved.
  2. The logged in user will be automatically redirected to the profile page since commit #9544ce6.
  3. The "Login button on the Navi of Forget Password page" and text alignment problems have been solved.
  4. For safety reasons, it is unsafe to display the password on the profile page, and the password has been encrypted by the MD5 algorithm and stored in the DB, which is almost unrevertable.
  5. The interactive registration form validator has been added

@jikang1116
Copy link
Collaborator

jikang1116 commented May 7, 2024 via email

@Phyo09
Copy link
Collaborator

Phyo09 commented May 8, 2024

  1. Profile's page tile is currently {{userID}} - Profile - Adventurer Guild but User ID is too long. (Solved)
  2. index.html is error (no route under app.py and not using as well). Deleting? (Solved - index.html is home page while logged out)
  3. There is no option for user to go to Sign page without URL? (Solved)
    image
  4. I cannot find modifycenter under templates folder. T_T (Solved - different name is used)
  5. forgetpassword page, Currently logged in but the page is accessible and shown with Home, Login, Sign Up navigation bar. Can we put current_user.is_authenticated for forgotpassword as well? (Solved)

@Phyo09
Copy link
Collaborator

Phyo09 commented May 8, 2024

  1. The password is not shown in the profile page, this is to ensure safety. 2. A PIN code, or Personal Identification Number, is a numeric or alphanumeric password used in the process of authenticating a user accessing a system. This code is typically a series of digits and is used to ensure that access to a device, network, or data is secured against unauthorized access.

    On Tue, 7 May 2024 at 03:08, Phyo09 @.> wrote: Password on Profile page, 1. Why i cannot see the current password on profile page? Can we use hide function instead? 2. When changing password, why i need to provide PIN code? I am not changing my PIN Code? I put the new one in, but the PIN code never changed. What is the purpose of PIN code here? — Reply to this email directly, view it on GitHub <#33 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVH4I4QKFXHUGDX4OUBR563ZA7IL5AVCNFSM6AAAAABG3ZLSOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJWG4YTSNRRGQ . You are receiving this because you were assigned.Message ID: @.>

So PIN code is numeric? Currently, on the webpage, it says LETTERS (letters means alphabet). Wanna change the vocab on the webpage? (Solved)
image

@xosadmin
Copy link
Owner Author

xosadmin commented May 9, 2024

  1. Profile's page tile is currently {{userID}} - Profile - Adventurer Guild but User ID is too long.

  2. index.html is error (no route under app.py and not using as well). Deleting?

  3. There is no option for user to go to Sign page without URL?

image

  1. I cannot find modifycenter under templates folder. T_T

  2. forgetpassword page, Currently logged in but the page is accessible and shown with Home, Login, Sign Up navigation bar. Can we put current_user.is_authenticated for forgotpassword as well? (Issue is created)

The Sign page can only show ONCE while user login. This is optional.

@Phyo09
Copy link
Collaborator

Phyo09 commented May 9, 2024

Updated issues which are solved and which are still pending.

Issues

  1. The website design is not aligned and inconsistent style. (Solved)
  2. We can make navigation centralize, meaning no need to repeat navigation html code for every pages. we can use external html embedded within the html pages. (Solved)
  3. index.html is error (no route under app.py and not using as well). Deleting? (Solved)
  4. Definition of PIN on Singup? (Suggestion, not letters, should be digits) (Solved)
  5. While changing password while logged in, validation "The password can not lower than 4 words and higher than 32 words." does not apply here. (Solved)
  6. Invalid PIN Code! redirect to below (Solved)
    image
    instead of below
    image
    When redirect to the page, to load the form as well.

@xosadmin
Copy link
Owner Author

xosadmin commented May 9, 2024

  1. Upon group meeting result, there is no issue with the design, just misunderstanding
  2. Upon testing, there is no index.html bug. But, in order to enhance the user experience, /index route has been added
  3. PIN definition has been clearfied on the registration page
  4. The password length validator is fixed
  5. Invalid PIN code bug fixed

Repository owner deleted a comment from Phyo09 May 9, 2024
@Phyo09
Copy link
Collaborator

Phyo09 commented May 10, 2024

Request

  1. Time Limit is accepting letters! (Solved)

  2. on My Request page, Time Limit is empty regardless it is letters or numbers. (Solved)

  3. And also NPC means Non-player character right? But I am a user, so should we use the word "requester" instead? (Solved - Since this is RPG-style, the NPC is defined as the requester.)

  4. Can we use Name instead of UserID? Numbers are not user friendly. (Future Implemention)

  5. Time limitation function is not working or not implementing? The number is always the same and never expired. (Future Implementation)

  6. For search function, I would like to recommend to put the requester detail (NPC or name) and the status of request (i.e., Completed/Solved, Available). (?)
    Its a bit weird that it said "Here are all requests posed by NPC" but only Valid/Available requests are shown. But when I searched, it popped up Completed requests. FYI, there is bootstrap function for filtering the table.
    image

  7. Delete function is not working. Addition, what will happen when its deleted? Will i get money back? (Solved)

To-do List

  1. instead of Request ID, isn't it convenient to see Title instead? (Solved)
  2. Why Completed Request is here plus why Completed Request is shown first? I know it's ordered by ID but when there are many completed requests, it's hard for the user to scroll all the way down.
    Suggestions:
  • Include Search
  • Separate 2 tables. One for Available accepted requests and another table for Completed accepted requests
  • Table filter function (Future Implementation)

Shop (Good)

Leaderboard

  1. Isn't easier/more user friendly to use User's Name then User ID? (Future Implemention)

  2. Suggestions:
    We can also include the numbers of requests the user made and the requests he answered. (Solved)

Community (Good)

Chatroom (Pending) - Next Thread

@xosadmin
Copy link
Owner Author

xosadmin commented May 11, 2024

  1. The time limit column has been fixed.
  2. timelimit don't showing on My Request has been fixed
  3. Show request title on Todo page is a good idea, and it has been implemented
  4. We did not implemented usernames yet. I think this can be implemented in future verisons
  5. Since this is RPG-style, the NPC is defined as the requester.
  6. The Delete function is on the Request page. Rewards will be refunded if NPC deletes his request
  7. THe search function can work with requests with all status by default. The request state filter can be implemented in future
  8. The count of requests is a good idea. It has been implemented.

All in all, some suggestions for future development have been added to the future planning list.

@Phyo09
Copy link
Collaborator

Phyo09 commented May 12, 2024

Chat

  • alert is popping up for the chat convo (chat means instant?) - Solved
  • Cannot text to myself (showing Invalid Destination User!)

Helpcenter navigation tab is not working.
if you want to exclude, kindly remove below link from base.html
<li class="{% if request.path == '/help' %}active{% endif %}"><a href="/help">Help Center</a></li>


need to rename the html files' name to standardize

  • change_profile.html to modifycenter.html
  • confirm_buy.html to confirmpayment.html
    ** which format are we using (e.g., new_request.html or newRequest.html)

Reorder app.py accordingly to the function.


I have create new pull request includes below changes as summarized:

  • chat convo alert is removed
  • Cannot update to duplicated email address
  • Redundant validations are removed and used built-in validation instead as possible as it can.
  • instead of id, used class to display error msg
  • javascript for checking old pin and new pin is updated. (No longer comparing passwords <-old error )
  • Changed variable name to meaningful one (e.g, Signup page's #whydisableSubButt to #registerErrorDisplay)
  • Updated the error msg accordingly.

@xosadmin
Copy link
Owner Author

xosadmin commented May 13, 2024

  1. For Chatroom, Chatroom has designed constraints to prevent users from sending messages to themselves or non-existent users.
  2. Thanks for your pull request. However, upon reviewing your code, the verifyEmail() is redundancy as checkEmail() function do the same thing. Also, there is a conflict that caused by main.db and helpcenter.html. You need to solve this conflict before sending pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants