Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build error for SONOFF_DUAL configuration #148

Closed
xoseperez opened this issue May 31, 2017 · 5 comments
Closed

Build error for SONOFF_DUAL configuration #148

xoseperez opened this issue May 31, 2017 · 5 comments
Labels
bug minor

Comments

@xoseperez
Copy link
Owner

Originally reported by: Gerben (Bitbucket: mrgerben, GitHub: Unknown)

Build error when enabling the SONOFF_DUAL configuration:

espurna:105: error: #if with no expression

 #if SONOFF_DUAL

Proposal:
Change the #if to #ifdef (see attached file)
@xoseperez
Copy link
Owner Author

Original comment by treowayne (Bitbucket: treowayne, GitHub: Unknown):

I ran into the same problem, and this fixed it right up. Thanks.

@xoseperez
Copy link
Owner Author

Original comment by Ingo Heinicke (Bitbucket: skyynet, GitHub: skyynet):

@xoseperez Why not change this in 1.8.2 and set milestone? Simple bugfix.

@xoseperez
Copy link
Owner Author

Issue #151 was marked as a duplicate of this issue.

@xoseperez
Copy link
Owner Author

Removing milestone: 1.8.2 (automated comment)

@xoseperez
Copy link
Owner Author

Fixed with 1.8.2

@xoseperez xoseperez mentioned this issue Jan 24, 2018
Closed
xoseperez added a commit that referenced this issue Jan 24, 2018
@xoseperez
Issue #148. Fix bug in conditional compilation check
5e546d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xoseperez