Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling double tap to reduce single tap delay #170

Closed
xoseperez opened this issue Jul 21, 2017 · 7 comments
Closed

Allow disabling double tap to reduce single tap delay #170

xoseperez opened this issue Jul 21, 2017 · 7 comments
Labels
enhancement New feature or request major

Comments

@xoseperez
Copy link
Owner

Originally reported by: Abílio Costa (Bitbucket: amfcosta, GitHub: Unknown)


Currently there is a slight delay when pressing the button to turn the relay on, which is expected since the software needs that to distinguish a single from a double tap. This is very noticeable on a Sonoff Touch.

Since Espurna already goes into AP Mode if the wifi connection fails, disabling the double tap and getting instant single tap would be great!

@xoseperez
Copy link
Owner Author

This will require to change the DebouceEvent library. Changing the CLICK_REPEAT_DELAY setting to 0 in the DebounceEvent.h effectively removes the double click functionality and the library reports the clicks immediately.

@xoseperez
Copy link
Owner Author

Original comment by Abílio Costa (Bitbucket: amfcosta, GitHub: Unknown):


Could this be a parameter passed to the library instead of being a constant?

@xoseperez
Copy link
Owner Author

I've just updated both the library and the ESPurna code to be able to pass the repeat_delay value in the constructor of the library. Check #0535fce in dev branch.

@xoseperez
Copy link
Owner Author

Original comment by Abílio Costa (Bitbucket: amfcosta, GitHub: Unknown):


Oh that's cool! I've not setup the build environment yet (I'm using the compiled files here on bitbucket), but I'll try it if I set it up.

@xoseperez
Copy link
Owner Author

Original comment by Abílio Costa (Bitbucket: amfcosta, GitHub: Unknown):


By the way, would this be configurable trough the web interface?

@xoseperez
Copy link
Owner Author

Yes, it can be configured from the web interface.
Pushed with 1.8.3.

@xoseperez
Copy link
Owner Author

Removing milestone: 1.8.3 (automated comment)

@xoseperez xoseperez added major 1.8.2 enhancement New feature or request labels Jan 24, 2018
xoseperez added a commit that referenced this issue Jan 24, 2018
…uble click option and get faster click responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major
Projects
None yet
Development

No branches or pull requests

1 participant