Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EventsSensor #1771

Merged
merged 7 commits into from
Jun 29, 2019
Merged

Update EventsSensor #1771

merged 7 commits into from
Jun 29, 2019

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Jun 11, 2019 •
edited

  • cache ms<->clockcycles conversions
  • move callback invocation outside of ISR handler
  • retain last event value

std::queue methods are still not technically in iram, but it might not matter for use-case with low interrupt count.

@mcspr
Update EventSensor
a351a7f 
- cache ms<->clockcycles conversions
- move callback invocation outside of ISR handler
@mcspr
push event only on trigger
40999f1
@mcspr
retain last event value
fb27bba
@mcspr mcspr mentioned this pull request Jun 11, 2019
Closed
@mcspr mcspr merged commit 0d76910 into xoseperez:dev Jun 29, 2019
@mcspr mcspr deleted the events/callback branch June 29, 2019 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mcspr