Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for JINVOO VALVE SM-AW713 #1774

Merged
merged 5 commits into from
Jun 23, 2019
Merged

add support for JINVOO VALVE SM-AW713 #1774

merged 5 commits into from
Jun 23, 2019

Conversation

reaper7
Copy link
Contributor

@reaper7 reaper7 commented Jun 13, 2019

jinvoo-valve-sm-aw713

@reaper7
Copy link
Contributor Author

reaper7 commented Jun 14, 2019

Type: Other
Board: Jinvoo SM-AW713
Build flag: JINVOO_VALVE_SM_AW713
Description: motorized valve

Initial reflashing from original Tuya firmware
to thirdparty firmware like espurna should be done with:
https://github.com/ct-Open-Source/tuya-convert

I have converted my two valves in this way and they work with espurna very well.

@mcspr
Copy link
Collaborator

mcspr commented Jun 14, 2019

Thanks!

Can you please also add platformio.ini entries for the .bin releases?
And I think it can also go into the readme here? https://github.com/xoseperez/espurna#embedded-switches (with images/devices/..pic..)

@reaper7
Copy link
Contributor Author

reaper7 commented Jun 14, 2019

image added by this commit:
2bec5e5

I think it should be in OTHER group
https://github.com/xoseperez/espurna#other-devices

and in https://github.com/xoseperez/espurna/wiki/Hardware#other
with this description:
Type: Other
Board: Jinvoo SM-AW713
Build flag: JINVOO_VALVE_SM_AW713
Description: motorized valve

about platformio.ini, I do not use myself, it's hard for me to guess what to write.
it seems that the entry should look similar to itead-sonoff-basic, flash size is the same.

@mcspr
Copy link
Collaborator

mcspr commented Jun 16, 2019

No problem, I'll update the pio files then.
And right,, OTHER section is a better fit (not exactly a switch).

also, for #1458 we should probably in have a general info for tuya upgrade method. Sadly, looking at recent issues at https://github.com/ct-Open-Source/tuya-convert/issues, newest devices do not support it :/

@reaper7
Copy link
Contributor Author

reaper7 commented Jun 16, 2019

About newest devices, yes, there may be a problem, although tuya has forwarded patch implementation to individual brands (as written here: https://github.com/ct-Open-Source/tuya-convert#procedure).
But we know how the eastern producers work (sell and forget) :)
Most of the less popular devices, already on sale, will never receive this patch...

@mcspr
Copy link
Collaborator

mcspr commented Jun 23, 2019

I added device page to the wiki and some basic tuya description. Idk if it is worth inserting exact steps from tuya-convert readme though, but I added general description of that patch and how to flash specific .bin

@mcspr mcspr merged commit bf3caf3 into xoseperez:dev Jun 23, 2019
@mcspr mcspr added this to the 1.13.6 milestone Jun 23, 2019
mcspr added a commit to mcspr/espurna that referenced this pull request Jun 23, 2019
r3wald pushed a commit to r3wald/espurna-wiki that referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants