Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: update ota.py #2020

Merged
merged 11 commits into from
Dec 20, 2019
Merged

Scripts: update ota.py #2020

merged 11 commits into from
Dec 20, 2019

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Nov 27, 2019

  • follow up for Scripts: memanalyser fixes #2014 , drop py2, try to follow pylint advice (not everything yet), restructure script into functions, fix argparse
  • follow up for Python cleanup #1526, use threading helpers and zeroconf discovery through class object
  • change default behaviour to print immediately when device is discovered, make --sort optional
  • slightly increase timeout and add --timeout NUM

@mcspr
Copy link
Collaborator Author

mcspr commented Dec 9, 2019

Note about the 7bf7aa6 merge change. Using // to avoid nesting ints

per https://docs.python.org/3.8/tutorial/introduction.html#numbers:

Division (/) always returns a float. To do floor division and get an integer result (discarding any fractional result) you can use the // operator; to calculate the remainder you can use %

@mcspr mcspr added this to the 1.14.1 milestone Dec 9, 2019
@mcspr mcspr merged commit 9edccd1 into xoseperez:dev Dec 20, 2019
@mcspr mcspr deleted the util/ota-py3 branch December 20, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant